fix: demo stub robustness — DB timeout, encoding, connectivity#119
Merged
Conversation
…checks - _is_postgres(): check actual connectivity with 3s timeout, not just dialect - tool_search_similar(): catch DB connection errors, return error dict - run_script(): use UTF-8 encoding + PYTHONIOENCODING=utf-8 for subprocess - get_engine(): set connect_timeout=5 for psycopg to avoid long hangs Fixes tagent demo hanging on unavailable PostgreSQL and GBK encoding errors on Windows. Demo now completes in ~38s (was infinite hang).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tagent demohanging indefinitely when PostgreSQL is unavailableChanges
_is_postgres()— check actual DB connectivity with 3s timeout, not just SQLAlchemy dialecttool_search_similar()— catch connection errors gracefully, return error dict instead of crashingrun_script()— use UTF-8 encoding +PYTHONIOENCODING=utf-8for subprocess (fixes GBK decode errors on Windows)get_engine()— setconnect_timeout=5for psycopg to avoid 30s default timeoutTest plan
tagent democompletes with exit 0, all 4 steps pass